Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Docker in GitLab #1235

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Upgrade Docker in GitLab #1235

merged 1 commit into from
Feb 2, 2022

Conversation

UnsolvedCypher
Copy link
Contributor

Closes #1232

Upgrade to the latest GitLab Omnibus Docker. This ensures that we can test the plugin against a modern version of GitLab, and also substantially simplifies the docker-compose setup.

@UnsolvedCypher UnsolvedCypher requested a review from a team as a code owner February 2, 2022 00:54
basil
basil approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Would be great to also get the Docker-based Maven integration tests working again too. If you get it working locally I can hook it up on the GitHub/Jenkins side to run on all PR builds.

@basil basil merged commit dac0c6e into jenkinsci:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker GitLab version is old
2 participants
@UnsolvedCypher @basil